unixfs: remove `Get` prefix from `FSNode` accessors

See https://golang.org/doc/effective_go.html#Getters.

License: MIT
Signed-off-by: Lucas Molas <schomatis@gmail.com>

importer/helpers/helpers.go

@@ -77,7 +77,7 @@ func (n *UnixfsNode) Set(other *UnixfsNode) {
 	n.raw = other.raw
 	n.rawnode = other.rawnode
 	if other.ufmt != nil {
-		n.ufmt.SetData(other.ufmt.GetData())
+		n.ufmt.SetData(other.ufmt.Data())
 	}
 }
 

mfs/file.go

@@ -60,7 +60,7 @@ func (fi *File) Open(flags int, sync bool) (FileDescriptor, error) {
 			return nil, err
 		}
 
-		switch fsn.GetType() {
+		switch fsn.Type() {
 		default:
 			return nil, fmt.Errorf("unsupported fsnode type for 'file'")
 		case ft.TSymlink:

mfs/mfs_test.go

@@ -852,7 +852,7 @@ func TestFlushing(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	if fsnode.GetType() != ft.TDirectory {
+	if fsnode.Type() != ft.TDirectory {
 		t.Fatal("root wasnt a directory")
 	}
 

unixfs/archive/tar/writer.go

@@ -78,7 +78,7 @@ func (w *Writer) WriteNode(nd ipld.Node, fpath string) error {
 			return err
 		}
 
-		switch fsNode.GetType() {
+		switch fsNode.Type() {
 		case upb.Data_Metadata:
 			fallthrough
 		case upb.Data_Directory, upb.Data_HAMTShard:
@@ -88,7 +88,7 @@ func (w *Writer) WriteNode(nd ipld.Node, fpath string) error {
 		case upb.Data_File:
 			return w.writeFile(nd, fsNode, fpath)
 		case upb.Data_Symlink:
-			return writeSymlinkHeader(w.TarW, string(fsNode.GetData()), fpath)
+			return writeSymlinkHeader(w.TarW, string(fsNode.Data()), fpath)
 		default:
 			return ft.ErrUnrecognizedType
 		}

unixfs/io/dagreader.go

@@ -49,7 +49,7 @@ func NewDagReader(ctx context.Context, n ipld.Node, serv ipld.NodeGetter) (DagRe
 			return nil, err
 		}
 
-		switch fsNode.GetType() {
+		switch fsNode.Type() {
 		case ftpb.Data_Directory, ftpb.Data_HAMTShard:
 			// Dont allow reading directories
 			return nil, ErrIsDir

unixfs/io/pbdagreader.go

@@ -52,7 +52,7 @@ func NewPBFileReader(ctx context.Context, n *mdag.ProtoNode, file *ft.FSNode, se
 	curLinks := getLinkCids(n)
 	return &PBDagReader{
 		serv:     serv,
-		buf:      NewBufDagReader(file.GetData()),
+		buf:      NewBufDagReader(file.Data()),
 		promises: make([]*ipld.NodePromise, len(curLinks)),
 		links:    curLinks,
 		ctx:      fctx,
@@ -105,7 +105,7 @@ func (dr *PBDagReader) precalcNextBuf(ctx context.Context) error {
 			return fmt.Errorf("incorrectly formatted protobuf: %s", err)
 		}
 
-		switch fsNode.GetType() {
+		switch fsNode.Type() {
 		case ftpb.Data_Directory, ftpb.Data_HAMTShard:
 			// A directory should not exist within a file
 			return ft.ErrInvalidDirLocation
@@ -113,7 +113,7 @@ func (dr *PBDagReader) precalcNextBuf(ctx context.Context) error {
 			dr.buf = NewPBFileReader(dr.ctx, nxt, fsNode, dr.serv)
 			return nil
 		case ftpb.Data_Raw:
-			dr.buf = NewBufDagReader(fsNode.GetData())
+			dr.buf = NewBufDagReader(fsNode.Data())
 			return nil
 		case ftpb.Data_Metadata:
 			return errors.New("shouldnt have had metadata object inside file")
@@ -240,12 +240,12 @@ func (dr *PBDagReader) Seek(offset int64, whence int) (int64, error) {
 
 		// left represents the number of bytes remaining to seek to (from beginning)
 		left := offset
-		if int64(len(dr.file.GetData())) >= offset {
+		if int64(len(dr.file.Data())) >= offset {
 			// Close current buf to close potential child dagreader
 			if dr.buf != nil {
 				dr.buf.Close()
 			}
-			dr.buf = NewBufDagReader(dr.file.GetData()[offset:])
+			dr.buf = NewBufDagReader(dr.file.Data()[offset:])
 
 			// start reading links from the beginning
 			dr.linkPosition = 0
@@ -254,7 +254,7 @@ func (dr *PBDagReader) Seek(offset int64, whence int) (int64, error) {
 		}
 
 		// skip past root block data
-		left -= int64(len(dr.file.GetData()))
+		left -= int64(len(dr.file.Data()))
 
 		// iterate through links and find where we need to be
 		for i := 0; i < dr.file.NumChildren(); i++ {
@@ -301,7 +301,7 @@ func (dr *PBDagReader) Seek(offset int64, whence int) (int64, error) {
 		// for this seems to be good(-enough) solution as it's only returned by
 		// precalcNextBuf when we step out of file range.
 		// This is needed for gateway to function properly
-		if err == io.EOF && dr.file.GetType() == ftpb.Data_File {
+		if err == io.EOF && dr.file.Type() == ftpb.Data_File {
 			return -1, nil
 		}
 		return n, err

unixfs/unixfs.go

@@ -217,15 +217,15 @@ func (n *FSNode) NumChildren() int {
 	return len(n.format.Blocksizes)
 }
 
-// GetData retrieves the `Data` field from the internal `format`.
-func (n *FSNode) GetData() []byte {
+// Data retrieves the `Data` field from the internal `format`.
+func (n *FSNode) Data() []byte {
 	return n.format.GetData()
 }
 
 // SetData sets the `Data` field from the internal `format`
 // updating its `Filesize`.
 func (n *FSNode) SetData(newData []byte) {
-	n.UpdateFilesize(int64(len(newData) - len(n.GetData())))
+	n.UpdateFilesize(int64(len(newData) - len(n.Data())))
 	n.format.Data = newData
 }
 
@@ -237,8 +237,8 @@ func (n *FSNode) UpdateFilesize(filesizeDiff int64) {
 		int64(n.format.GetFilesize()) + filesizeDiff))
 }
 
-// GetType retrieves the `Type` field from the internal `format`.
-func (n *FSNode) GetType() pb.Data_DataType {
+// Type retrieves the `Type` field from the internal `format`.
+func (n *FSNode) Type() pb.Data_DataType {
 	return n.format.GetType()
 }