提交 390f4d74 作者: Brian Tiger Chow

readability(util) Do -> ContextDo

@jbenet
上级 40c5cca1
...@@ -60,7 +60,7 @@ func NewIpfsNetwork(ctx context.Context, listen []ma.Multiaddr, local peer.Peer, ...@@ -60,7 +60,7 @@ func NewIpfsNetwork(ctx context.Context, listen []ma.Multiaddr, local peer.Peer,
// DialPeer attempts to establish a connection to a given peer. // DialPeer attempts to establish a connection to a given peer.
// Respects the context. // Respects the context.
func (n *IpfsNetwork) DialPeer(ctx context.Context, p peer.Peer) error { func (n *IpfsNetwork) DialPeer(ctx context.Context, p peer.Peer) error {
err := util.Do(ctx, func() error { err := util.ContextDo(ctx, func() error {
_, err := n.swarm.Dial(p) _, err := n.swarm.Dial(p)
return err return err
}) })
......
...@@ -2,7 +2,7 @@ package util ...@@ -2,7 +2,7 @@ package util
import "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" import "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
func Do(ctx context.Context, f func() error) error { func ContextDo(ctx context.Context, f func() error) error {
ch := make(chan error) ch := make(chan error)
......
...@@ -10,7 +10,7 @@ import ( ...@@ -10,7 +10,7 @@ import (
func TestDoReturnsContextErr(t *testing.T) { func TestDoReturnsContextErr(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background()) ctx, cancel := context.WithCancel(context.Background())
ch := make(chan struct{}) ch := make(chan struct{})
err := Do(ctx, func() error { err := ContextDo(ctx, func() error {
cancel() cancel()
ch <- struct{}{} // won't return ch <- struct{}{} // won't return
return nil return nil
...@@ -22,8 +22,8 @@ func TestDoReturnsContextErr(t *testing.T) { ...@@ -22,8 +22,8 @@ func TestDoReturnsContextErr(t *testing.T) {
func TestDoReturnsFuncError(t *testing.T) { func TestDoReturnsFuncError(t *testing.T) {
ctx := context.Background() ctx := context.Background()
expected := errors.New("expected to be returned by Do") expected := errors.New("expected to be returned by ContextDo")
err := Do(ctx, func() error { err := ContextDo(ctx, func() error {
return expected return expected
}) })
if err != expected { if err != expected {
...@@ -33,7 +33,7 @@ func TestDoReturnsFuncError(t *testing.T) { ...@@ -33,7 +33,7 @@ func TestDoReturnsFuncError(t *testing.T) {
func TestDoReturnsNil(t *testing.T) { func TestDoReturnsNil(t *testing.T) {
ctx := context.Background() ctx := context.Background()
err := Do(ctx, func() error { err := ContextDo(ctx, func() error {
return nil return nil
}) })
if err != nil { if err != nil {
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论