提交 528a7cbd 作者: Brian Tiger Chow

refactor(diagnostics) move proto to internal pb package

https://docs.google.com/document/d/1e8kOo3r51b2BWtTs_1uADIA5djfXhPT36s6eHVRIvaU/edit
上级 ec481b5a
...@@ -13,6 +13,7 @@ import ( ...@@ -13,6 +13,7 @@ import (
"github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
"github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/goprotobuf/proto" "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/goprotobuf/proto"
pb "github.com/jbenet/go-ipfs/diagnostics/internal/pb"
net "github.com/jbenet/go-ipfs/net" net "github.com/jbenet/go-ipfs/net"
msg "github.com/jbenet/go-ipfs/net/message" msg "github.com/jbenet/go-ipfs/net/message"
peer "github.com/jbenet/go-ipfs/peer" peer "github.com/jbenet/go-ipfs/peer"
...@@ -156,7 +157,7 @@ func AppendDiagnostics(data []byte, cur []*DiagInfo) []*DiagInfo { ...@@ -156,7 +157,7 @@ func AppendDiagnostics(data []byte, cur []*DiagInfo) []*DiagInfo {
} }
// TODO: this method no longer needed. // TODO: this method no longer needed.
func (d *Diagnostics) getDiagnosticFromPeer(ctx context.Context, p peer.Peer, mes *Message) ([]byte, error) { func (d *Diagnostics) getDiagnosticFromPeer(ctx context.Context, p peer.Peer, mes *pb.Message) ([]byte, error) {
rpmes, err := d.sendRequest(ctx, p, mes) rpmes, err := d.sendRequest(ctx, p, mes)
if err != nil { if err != nil {
return nil, err return nil, err
...@@ -164,13 +165,13 @@ func (d *Diagnostics) getDiagnosticFromPeer(ctx context.Context, p peer.Peer, me ...@@ -164,13 +165,13 @@ func (d *Diagnostics) getDiagnosticFromPeer(ctx context.Context, p peer.Peer, me
return rpmes.GetData(), nil return rpmes.GetData(), nil
} }
func newMessage(diagID string) *Message { func newMessage(diagID string) *pb.Message {
pmes := new(Message) pmes := new(pb.Message)
pmes.DiagID = proto.String(diagID) pmes.DiagID = proto.String(diagID)
return pmes return pmes
} }
func (d *Diagnostics) sendRequest(ctx context.Context, p peer.Peer, pmes *Message) (*Message, error) { func (d *Diagnostics) sendRequest(ctx context.Context, p peer.Peer, pmes *pb.Message) (*pb.Message, error) {
mes, err := msg.FromObject(p, pmes) mes, err := msg.FromObject(p, pmes)
if err != nil { if err != nil {
...@@ -190,7 +191,7 @@ func (d *Diagnostics) sendRequest(ctx context.Context, p peer.Peer, pmes *Messag ...@@ -190,7 +191,7 @@ func (d *Diagnostics) sendRequest(ctx context.Context, p peer.Peer, pmes *Messag
rtt := time.Since(start) rtt := time.Since(start)
log.Info("diagnostic request took: %s", rtt.String()) log.Info("diagnostic request took: %s", rtt.String())
rpmes := new(Message) rpmes := new(pb.Message)
if err := proto.Unmarshal(rmes.Data(), rpmes); err != nil { if err := proto.Unmarshal(rmes.Data(), rpmes); err != nil {
return nil, err return nil, err
} }
...@@ -198,7 +199,7 @@ func (d *Diagnostics) sendRequest(ctx context.Context, p peer.Peer, pmes *Messag ...@@ -198,7 +199,7 @@ func (d *Diagnostics) sendRequest(ctx context.Context, p peer.Peer, pmes *Messag
return rpmes, nil return rpmes, nil
} }
func (d *Diagnostics) handleDiagnostic(p peer.Peer, pmes *Message) (*Message, error) { func (d *Diagnostics) handleDiagnostic(p peer.Peer, pmes *pb.Message) (*pb.Message, error) {
log.Debug("HandleDiagnostic from %s for id = %s", p, pmes.GetDiagID()) log.Debug("HandleDiagnostic from %s for id = %s", p, pmes.GetDiagID())
resp := newMessage(pmes.GetDiagID()) resp := newMessage(pmes.GetDiagID())
d.diagLock.Lock() d.diagLock.Lock()
...@@ -259,7 +260,7 @@ func (d *Diagnostics) HandleMessage(ctx context.Context, mes msg.NetMessage) msg ...@@ -259,7 +260,7 @@ func (d *Diagnostics) HandleMessage(ctx context.Context, mes msg.NetMessage) msg
} }
// deserialize msg // deserialize msg
pmes := new(Message) pmes := new(pb.Message)
err := proto.Unmarshal(mData, pmes) err := proto.Unmarshal(mData, pmes)
if err != nil { if err != nil {
log.Error("Failed to decode protobuf message: %v", err) log.Error("Failed to decode protobuf message: %v", err)
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论