commands: fix opt.Description panic when desc was empty

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

commands/option.go

@@ -43,7 +43,10 @@ func (o *option) Type() reflect.Kind {
 }
 
 func (o *option) Description() string {
-	if o.description[len(o.description)-1] != '.' {
+	if len(o.description) == 0 {
+		return ""
+	}
+	if !strings.HasSuffix(o.description, ".") {
 		o.description += "."
 	}
 	if o.defaultVal != nil {

commands/option_test.go

 package commands
 
-import "testing"
+import (
+	"strings"
+	"testing"
+)
 
 func TestOptionValueExtractBoolNotFound(t *testing.T) {
 	t.Log("ensure that no error is returned when value is not found")
@@ -27,3 +30,16 @@ func TestOptionValueExtractWrongType(t *testing.T) {
 		t.Fatal("No error returned. Failure.")
 	}
 }
+
+func TestLackOfDescriptionOfOptionDoesNotPanic(t *testing.T) {
+	opt := BoolOption("a", "")
+	opt.Description()
+}
+
+func TestDotIsAddedInDescripton(t *testing.T) {
+	opt := BoolOption("a", "desc without dot")
+	dest := opt.Description()
+	if !strings.HasSuffix(dest, ".") {
+		t.Fatal("dot should have been added at the end of description")
+	}
+}