提交 5b5e17ed 作者: Brian Tiger Chow

style(bs:tx) rename receiver -> forwarder

上级 2edc03ac
...@@ -64,7 +64,7 @@ type BitSwap struct { ...@@ -64,7 +64,7 @@ type BitSwap struct {
// NewBitSwap creates a new BitSwap instance. It does not check its parameters. // NewBitSwap creates a new BitSwap instance. It does not check its parameters.
func NewBitSwap(p *peer.Peer, net swarm.Network, d ds.Datastore, r routing.IpfsRouting) *BitSwap { func NewBitSwap(p *peer.Peer, net swarm.Network, d ds.Datastore, r routing.IpfsRouting) *BitSwap {
receiver := receiver{} receiver := tx.Forwarder{}
sender := tx.NewBSNetService(context.Background(), &receiver) sender := tx.NewBSNetService(context.Background(), &receiver)
bs := &BitSwap{ bs := &BitSwap{
peer: p, peer: p,
......
package bitswap package transmission
import ( import (
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
bsmsg "github.com/jbenet/go-ipfs/bitswap/message" bsmsg "github.com/jbenet/go-ipfs/bitswap/message"
tx "github.com/jbenet/go-ipfs/bitswap/transmission"
peer "github.com/jbenet/go-ipfs/peer" peer "github.com/jbenet/go-ipfs/peer"
) )
// receiver breaks the circular dependency between bitswap and its sender // Forwarder breaks the circular dependency between bitswap and its sender
// NB: A sender is instantiated with a handler and this sender is then passed // NB: A sender is instantiated with a handler and this sender is then passed
// as a constructor argument to BitSwap. However, the handler is BitSwap! // as a constructor argument to BitSwap. However, the handler is BitSwap!
// Hence, this receiver. // Hence, this receiver.
type receiver struct { type Forwarder struct {
delegate tx.Receiver delegate Receiver
} }
func (r *receiver) ReceiveMessage( func (r *Forwarder) ReceiveMessage(
ctx context.Context, sender *peer.Peer, incoming bsmsg.BitSwapMessage) ( ctx context.Context, sender *peer.Peer, incoming bsmsg.BitSwapMessage) (
bsmsg.BitSwapMessage, *peer.Peer, error) { bsmsg.BitSwapMessage, *peer.Peer, error) {
if r.delegate == nil { if r.delegate == nil {
...@@ -24,6 +23,6 @@ func (r *receiver) ReceiveMessage( ...@@ -24,6 +23,6 @@ func (r *receiver) ReceiveMessage(
return r.delegate.ReceiveMessage(ctx, sender, incoming) return r.delegate.ReceiveMessage(ctx, sender, incoming)
} }
func (r *receiver) Delegate(delegate tx.Receiver) { func (r *Forwarder) Delegate(delegate Receiver) {
r.delegate = delegate r.delegate = delegate
} }
package bitswap package transmission
import ( import (
"testing" "testing"
...@@ -9,6 +9,8 @@ import ( ...@@ -9,6 +9,8 @@ import (
) )
func TestDoesntPanicIfDelegateNotPresent(t *testing.T) { func TestDoesntPanicIfDelegateNotPresent(t *testing.T) {
r := receiver{} fwdr := Forwarder{}
r.ReceiveMessage(context.Background(), &peer.Peer{}, bsmsg.New()) fwdr.ReceiveMessage(context.Background(), &peer.Peer{}, bsmsg.New())
} }
// TODO(brian): func TestForwardsMessageToDelegate(t *testing.T)
package network package transmission
import ( import (
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
......
package network package transmission
import ( import (
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论