Revert "mfs.Mkdir returns the final Directory it creates"

This reverts commit dfd98f27.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

core/commands/files/files.go

@@ -650,7 +650,7 @@ Examples:
 			flush = true
 		}
 
-		_, err = mfs.Mkdir(n.FilesRoot, dirtomake, dashp, flush)
+		err = mfs.Mkdir(n.FilesRoot, dirtomake, dashp, flush)
 		if err != nil {
 			res.SetError(err, cmds.ErrNormal)
 			return

core/coreunix/add.go

@@ -349,7 +349,7 @@ func (adder *Adder) addNode(node *dag.Node, path string) error {
 
 	dir := gopath.Dir(path)
 	if dir != "." {
-		if _, err := mfs.Mkdir(adder.mr, dir, true, false); err != nil {
+		if err := mfs.Mkdir(adder.mr, dir, true, false); err != nil {
 			return err
 		}
 	}
@@ -420,7 +420,7 @@ func (adder *Adder) addFile(file files.File) error {
 func (adder *Adder) addDir(dir files.File) error {
 	log.Infof("adding directory: %s", dir.FileName())
 
-	_, err := mfs.Mkdir(adder.mr, dir.FileName(), true, false)
+	err := mfs.Mkdir(adder.mr, dir.FileName(), true, false)
 	if err != nil {
 		return err
 	}

mfs/ops.go

@@ -100,9 +100,9 @@ func PutNode(r *Root, path string, nd *dag.Node) error {
 
 // Mkdir creates a directory at 'path' under the directory 'd', creating
 // intermediary directories as needed if 'mkparents' is set to true
-func Mkdir(r *Root, pth string, mkparents bool, flush bool) (*Directory, error) {
+func Mkdir(r *Root, pth string, mkparents bool, flush bool) error {
 	if pth == "" {
-		return nil, fmt.Errorf("no path given to Mkdir")
+		return fmt.Errorf("no path given to Mkdir")
 	}
 	parts := path.SplitList(pth)
 	if parts[0] == "" {
@@ -117,9 +117,9 @@ func Mkdir(r *Root, pth string, mkparents bool, flush bool) (*Directory, error)
 	if len(parts) == 0 {
 		// this will only happen on 'mkdir /'
 		if mkparents {
-			return nil, nil
+			return nil
 		}
-		return nil, fmt.Errorf("cannot create directory '/': Already exists")
+		return fmt.Errorf("cannot create directory '/': Already exists")
 	}
 
 	cur := r.GetValue().(*Directory)
@@ -128,16 +128,16 @@ func Mkdir(r *Root, pth string, mkparents bool, flush bool) (*Directory, error)
 		if err == os.ErrNotExist && mkparents {
 			mkd, err := cur.Mkdir(d)
 			if err != nil {
-				return nil, err
+				return err
 			}
 			fsn = mkd
 		} else if err != nil {
-			return nil, err
+			return err
 		}
 
 		next, ok := fsn.(*Directory)
 		if !ok {
-			return nil, fmt.Errorf("%s was not a directory", path.Join(parts[:i]))
+			return fmt.Errorf("%s was not a directory", path.Join(parts[:i]))
 		}
 		cur = next
 	}
@@ -145,18 +145,18 @@ func Mkdir(r *Root, pth string, mkparents bool, flush bool) (*Directory, error)
 	final, err := cur.Mkdir(parts[len(parts)-1])
 	if err != nil {
 		if !mkparents || err != os.ErrExist || final == nil {
-			return nil, err
+			return err
 		}
 	}
 
 	if flush {
 		err := final.Flush()
 		if err != nil {
-			return nil, err
+			return err
 		}
 	}
 
-	return final, nil
+	return nil
 }
 
 func Lookup(r *Root, path string) (FSNode, error) {