Merge pull request #3021 from ipfs/fix/auto-migrate-windows

extract binaries with .exe name on windows

repo/fsrepo/migrations/migrations.go

@@ -25,8 +25,18 @@ func init() {
 
 const migrations = "fs-repo-migrations"
 
+func migrationsBinName() string {
+	switch runtime.GOOS {
+	case "windows":
+		return migrations + ".exe"
+	default:
+		return migrations
+	}
+}
+
 func RunMigration(newv int) error {
-	migrateBin := "fs-repo-migrations"
+	migrateBin := migrationsBinName()
+
 	fmt.Println("  => checking for migrations binary...")
 
 	var err error
@@ -78,7 +88,7 @@ func GetMigrations() (string, error) {
 		return "", fmt.Errorf("tempdir: %s", err)
 	}
 
-	out := filepath.Join(dir, migrations)
+	out := filepath.Join(dir, migrationsBinName())
 
 	err = GetBinaryForVersion(migrations, migrations, DistPath, latest, out)
 	if err != nil {
@@ -202,6 +212,7 @@ func GetBinaryForVersion(distname, binnom, root, vers, out string) error {
 	switch runtime.GOOS {
 	case "windows":
 		archive = "zip"
+		binnom += ".exe"
 	default:
 		archive = "tar.gz"
 	}

repo/fsrepo/migrations/unpack.go

@@ -87,7 +87,7 @@ func unpackZip(dist, binnom, path, out string) error {
 
 	var bin io.ReadCloser
 	for _, fis := range zipr.File {
-		if fis.Name == dist+"/"+binnom+".exe" {
+		if fis.Name == dist+"/"+binnom {
 			rc, err := fis.Open()
 			if err != nil {
 				return fmt.Errorf("error extracting binary from archive: %s", err)