Merge pull request #1437 from lgierth/metrics-fix

swarm: fix peers_total metric

p2p/net/swarm/swarm.go

@@ -289,11 +289,11 @@ func (n *ps2netNotifee) ClosedStream(s *ps.Stream) {
 type metricsNotifiee Swarm
 
 func (nn *metricsNotifiee) Connected(n inet.Network, v inet.Conn) {
-	peersTotalGauge(n.LocalPeer()).Inc()
+	peersTotalGauge(n.LocalPeer()).Set(float64(len(n.Conns())))
 }
 
 func (nn *metricsNotifiee) Disconnected(n inet.Network, v inet.Conn) {
-	peersTotalGauge(n.LocalPeer()).Dec()
+	peersTotalGauge(n.LocalPeer()).Set(float64(len(n.Conns())))
 }
 
 func (nn *metricsNotifiee) OpenedStream(n inet.Network, v inet.Stream) {}

p2p/net/swarm/swarm_net.go

@@ -58,12 +58,12 @@ func (n *Network) LocalPeer() peer.ID {
 	return n.Swarm().LocalPeer()
 }
 
-// Peers returns the connected peers
+// Peers returns the known peer IDs from the Peerstore
 func (n *Network) Peers() []peer.ID {
 	return n.Swarm().Peers()
 }
 
-// Peers returns the connected peers
+// Peers returns the Peerstore, which tracks known peers
 func (n *Network) Peerstore() peer.Peerstore {
 	return n.Swarm().peers
 }