t0090: test ipfs get offline as well as online

To do that the current tests are move inside a
test_get_cmd() function. This function is then first
called before running the daemon for offline tests
and then after starting the daemon for online tests.

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>

test/sharness/t0090-get.sh

@@ -9,107 +9,116 @@ test_description="Test get command"
 . lib/test-lib.sh
 
 test_init_ipfs
-test_launch_ipfs_daemon
 
-test_expect_success "'ipfs get --help' succeeds" '
+# we use a function so that we can run it both offline + online
+test_get_cmd() {
+
+	test_expect_success "'ipfs get --help' succeeds" '
 	  ipfs get --help >actual
-'
+	'
 	
-test_expect_success "'ipfs get --help' output looks good" '
+	test_expect_success "'ipfs get --help' output looks good" '
 	  egrep "ipfs get.*<ipfs-path>" actual >/dev/null ||
 	  test_fsh cat actual
-'
+	'
 	
-test_expect_success "ipfs get succeeds" '
+	test_expect_success "ipfs get succeeds" '
 	  echo "Hello Worlds!" >data &&
 	  HASH=`ipfs add -q data` &&
 	  ipfs get "$HASH" >actual
-'
+	'
 	
-test_expect_success "ipfs get output looks good" '
+	test_expect_success "ipfs get output looks good" '
 	  printf "%s\n\n" "Saving file(s) to $HASH" >expected &&
 	  test_cmp expected actual
-'
+	'
 	
-test_expect_success "ipfs get file output looks good" '
+	test_expect_success "ipfs get file output looks good" '
 	  test_cmp "$HASH" data
-'
+	'
 	
-test_expect_success "ipfs get errors when trying to overwrite a file" '
+	test_expect_success "ipfs get errors when trying to overwrite a file" '
 	  test_must_fail ipfs get "$HASH" >actual &&
 	  rm "$HASH"
-'
+	'
 	
-test_expect_success "ipfs get -a succeeds" '
+	test_expect_success "ipfs get -a succeeds" '
 	  ipfs get "$HASH" -a >actual
-'
+	'
 	
-test_expect_success "ipfs get -a output looks good" '
+	test_expect_success "ipfs get -a output looks good" '
 	  printf "%s\n\n" "Saving archive to $HASH.tar" >expected &&
 	  test_cmp expected actual
-'
+	'
 	
-test_expect_success "ipfs get -a archive output is valid" '
+	test_expect_success "ipfs get -a archive output is valid" '
 	  tar -xf "$HASH".tar &&
 	  test_cmp "$HASH" data &&
 	  rm "$HASH".tar &&
 	  rm "$HASH"
-'
+	'
 	
-test_expect_success "ipfs get -a -C succeeds" '
+	test_expect_success "ipfs get -a -C succeeds" '
 	  ipfs get "$HASH" -a -C >actual
-'
+	'
 	
-test_expect_success "ipfs get -a -C output looks good" '
+	test_expect_success "ipfs get -a -C output looks good" '
 	  printf "%s\n\n" "Saving archive to $HASH.tar.gz" >expected &&
 	  test_cmp expected actual
-'
+	'
 	
-# TODO(mappum)
-test_expect_failure "gzipped tar archive output is valid" '
+	# TODO(mappum)
+	test_expect_failure "gzipped tar archive output is valid" '
 	  tar -zxf "$HASH".tar.gz &&
 	  test_cmp "$HASH" data &&
 	  rm "$HASH".tar.gz &&
 	  rm "$HASH"
-'
+	'
 	
-test_expect_success "ipfs get succeeds (directory)" '
-  mkdir dir &&
+	test_expect_success "ipfs get succeeds (directory)" '
+	  mkdir -p dir &&
 	  touch dir/a &&
-  mkdir dir/b &&
+	  mkdir -p dir/b &&
 	  echo "Hello, Worlds!" >dir/b/c &&
 	  HASH2=`ipfs add -r -q dir | tail -n 1` &&
 	  ipfs get "$HASH2" >actual
-'
+	'
 	
-test_expect_success "ipfs get output looks good (directory)" '
+	test_expect_success "ipfs get output looks good (directory)" '
 	  printf "%s\n\n" "Saving file(s) to $HASH2" >expected &&
 	  test_cmp expected actual
-'
+	'
 	
-test_expect_success "ipfs get output is valid (directory)" '
+	test_expect_success "ipfs get output is valid (directory)" '
 	  test_cmp dir/a "$HASH2"/a &&
 	  test_cmp dir/b/c "$HASH2"/b/c &&
 	  rm -r "$HASH2"
-'
+	'
 	
-test_expect_success "ipfs get -a -C succeeds (directory)" '
+	test_expect_success "ipfs get -a -C succeeds (directory)" '
 	  ipfs get "$HASH2" -a -C >actual
-'
+	'
 	
-test_expect_success "ipfs get -a -C output looks good (directory)" '
+	test_expect_success "ipfs get -a -C output looks good (directory)" '
 	  printf "%s\n\n" "Saving archive to $HASH2.tar.gz" >expected &&
 	  test_cmp expected actual
-'
+	'
 	
-# TODO(mappum)
-test_expect_failure "gzipped tar archive output is valid (directory)" '
+	# TODO(mappum)
+	test_expect_failure "gzipped tar archive output is valid (directory)" '
 	  tar -zxf "$HASH2".tar.gz &&
 	  test_cmp dir/a "$HASH2"/a &&
 	  test_cmp dir/b/c "$HASH2"/b/c &&
 	  rm -r "$HASH2"
-'
+	'
+}
 
+# should work offline
+test_get_cmd
+
+# should work online
+test_launch_ipfs_daemon
+test_get_cmd
 test_kill_ipfs_daemon
 
 test_done