hide fd adjusting code behind daemon feature flag

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>

cmd/ipfs/daemon.go

@@ -40,6 +40,7 @@ const (
 	unrestrictedApiAccessKwd  = "unrestricted-api"
 	unencryptTransportKwd     = "disable-transport-encryption"
 	enableGCKwd               = "enable-gc"
+	adjustFDLimitKwd          = "manage-fdlimit"
 	// apiAddrKwd    = "address-api"
 	// swarmAddrKwd  = "address-swarm"
 )
@@ -132,6 +133,7 @@ future version, along with this notice. Please move to setting the HTTP Headers.
 		cmds.BoolOption(unrestrictedApiAccessKwd, "Allow API access to unlisted hashes"),
 		cmds.BoolOption(unencryptTransportKwd, "Disable transport encryption (for debugging protocols)"),
 		cmds.BoolOption(enableGCKwd, "Enable automatic periodic repo garbage collection"),
+		cmds.BoolOption(adjustFDLimitKwd, "Check and raise file descriptor limits if needed"),
 
 		// TODO: add way to override addresses. tricky part: updating the config if also --init.
 		// cmds.StringOption(apiAddrKwd, "Address for the daemon rpc API (overrides config)"),
@@ -158,8 +160,11 @@ func daemonFunc(req cmds.Request, res cmds.Response) {
 	// let the user know we're going.
 	fmt.Printf("Initializing daemon...\n")
 
-	if err := fileDescriptorCheck(); err != nil {
-		log.Error("setting file descriptor limit: %s", err)
+	managefd, _, _ := req.Option(adjustFDLimitKwd).Bool()
+	if managefd {
+		if err := fileDescriptorCheck(); err != nil {
+			log.Error("setting file descriptor limit: %s", err)
+		}
 	}
 
 	ctx := req.InvocContext()

cmd/ipfs/ulimit_unix.go

@@ -9,7 +9,7 @@ import (
 	"syscall"
 )
 
-var ipfsFileDescNum = uint64(1024)
+var ipfsFileDescNum = uint64(2048)
 
 func init() {
 	if val := os.Getenv("IPFS_FD_MAX"); val != "" {

test/sharness/t0061-daemon-opts.sh

@@ -13,9 +13,6 @@ test_init_ipfs
 
 test_launch_ipfs_daemon --unrestricted-api --disable-transport-encryption
 
-test_expect_success "convert addresses from multiaddrs" '
-'
-
 gwyaddr=$GWAY_ADDR
 apiaddr=$API_ADDR