address comments and add some tests

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>

keystore/keystore.go

@@ -69,6 +69,8 @@ func (ks *FSKeystore) Put(name string, k ci.PrivKey) error {
 	_, err = os.Stat(kp)
 	if err == nil {
 		return ErrKeyExists
+	} else if !os.IsNotExist(err) {
+		return err
 	}
 
 	fi, err := os.Create(kp)

keystore/keystore_test.go

+package keystore
+
+import (
+	"fmt"
+	"io/ioutil"
+	"math/rand"
+	"sort"
+	"testing"
+
+	ci "gx/ipfs/QmfWDLQjGjVe4fr5CoztYW2DYYjRysMJrFe1RCsXLPTf46/go-libp2p-crypto"
+)
+
+type rr struct{}
+
+func (rr rr) Read(b []byte) (int, error) {
+	return rand.Read(b)
+}
+
+func privKeyOrFatal(t *testing.T) ci.PrivKey {
+	priv, _, err := ci.GenerateEd25519Key(rr{})
+	if err != nil {
+		t.Fatal(err)
+	}
+	return priv
+}
+
+func TestKeystoreBasics(t *testing.T) {
+	tdir, err := ioutil.TempDir("", "keystore-test")
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	ks, err := NewFSKeystore(tdir)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	l, err := ks.List()
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if len(l) != 0 {
+		t.Fatal("expected no keys")
+	}
+
+	k1 := privKeyOrFatal(t)
+	k2 := privKeyOrFatal(t)
+	k3 := privKeyOrFatal(t)
+	k4 := privKeyOrFatal(t)
+
+	err = ks.Put("foo", k1)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	err = ks.Put("bar", k2)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	l, err = ks.List()
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	sort.Strings(l)
+	if l[0] != "bar" || l[1] != "foo" {
+		t.Fatal("wrong entries listed")
+	}
+
+	if err := assertDirContents(tdir, []string{"foo", "bar"}); err != nil {
+		t.Fatal(err)
+	}
+
+	err = ks.Put("foo", k3)
+	if err == nil {
+		t.Fatal("should not be able to overwrite key")
+	}
+
+	if err := assertDirContents(tdir, []string{"foo", "bar"}); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := ks.Delete("bar"); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := assertDirContents(tdir, []string{"foo"}); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := ks.Put("beep", k3); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := ks.Put("boop", k4); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := assertDirContents(tdir, []string{"foo", "beep", "boop"}); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := assertGetKey(ks, "foo", k1); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := assertGetKey(ks, "beep", k3); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := assertGetKey(ks, "boop", k4); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := ks.Put("..///foo/", k1); err == nil {
+		t.Fatal("shouldnt be able to put a poorly named key")
+	}
+
+	if err := ks.Put("", k1); err == nil {
+		t.Fatal("shouldnt be able to put a key with no name")
+	}
+
+	if err := ks.Put(".foo", k1); err == nil {
+		t.Fatal("shouldnt be able to put a key with a 'hidden' name")
+	}
+}
+
+func TestMakeKeystoreNoDir(t *testing.T) {
+	_, err := NewFSKeystore("/this/is/not/a/real/dir")
+	if err == nil {
+		t.Fatal("shouldnt be able to make a keystore in a nonexistant directory")
+	}
+}
+
+func assertGetKey(ks Keystore, name string, exp ci.PrivKey) error {
+	out_k, err := ks.Get(name)
+	if err != nil {
+		return err
+	}
+
+	if !out_k.Equals(exp) {
+		return fmt.Errorf("key we got out didnt match expectation")
+	}
+
+	return nil
+}
+
+func assertDirContents(dir string, exp []string) error {
+	finfos, err := ioutil.ReadDir(dir)
+	if err != nil {
+		return err
+	}
+
+	if len(finfos) != len(exp) {
+		return fmt.Errorf("Expected %d directory entries", len(exp))
+	}
+
+	var names []string
+	for _, fi := range finfos {
+		names = append(names, fi.Name())
+	}
+
+	sort.Strings(names)
+	sort.Strings(exp)
+	if len(names) != len(exp) {
+		return fmt.Errorf("directory had wrong number of entries in it")
+	}
+
+	for i, v := range names {
+		if v != exp[i] {
+			return fmt.Errorf("had wrong entry in directory")
+		}
+	}
+	return nil
+}